Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux・Mac向けのサンプルコードを追加 #120

Merged
merged 14 commits into from
Apr 29, 2022

Conversation

PickledChair
Copy link
Member

@PickledChair PickledChair commented Apr 26, 2022

内容

example/cpp/unix ディレクトリに Linux・Mac 向けのサンプルコード (simple_tts.cpp) を追加します。サンプルのビルド方法は example/cpp/unix/README.md に記載しています。また、Windows 向けのサンプルコード #112 と同様に、サンプルコードがビルドできるかどうかをチェックするCIジョブも追加しています。

関連 Issue

VOICEVOX/voicevox_project#1

その他

改善したほうが良い点などありましたらご指摘ください……!

@Hiroshiba
Copy link
Member

@Yosshi999 さん、 @y-chan さん、もしよかったらレビュー頂けると心強いです・・・!

@Hiroshiba Hiroshiba requested review from y-chan and Yosshi999 April 27, 2022 16:09
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!
大丈夫そうでした...!

Copy link
Contributor

@Yosshi999 Yosshi999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
WSLで動作を確認しました

@Yosshi999 Yosshi999 merged commit 6135dff into VOICEVOX:main Apr 29, 2022
y-chan pushed a commit to SHAREVOX/sharevox_core that referenced this pull request Sep 1, 2022
* linux・mac向けのサンプルコードを追加

* add .gitignore for unix cpp sample

* add README.md for unix cpp sample

* fix example/cpp/unix/README.md

* fix README.md

* add build-unix-cpp-example workflow

* set fail-fast to false

* download onnx runtime

* mkdir download

* remove extra condition

* define onnxruntime_lib_name and core_name

* fix example/cpp/unix/README.md

* trivial change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants