-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux・Mac向けのサンプルコードを追加 #120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Yosshi999 さん、 @y-chan さん、もしよかったらレビュー頂けると心強いです・・・! |
y-chan
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMです!
大丈夫そうでした...!
Yosshi999
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
WSLで動作を確認しました
y-chan
pushed a commit
to SHAREVOX/sharevox_core
that referenced
this pull request
Sep 1, 2022
* linux・mac向けのサンプルコードを追加 * add .gitignore for unix cpp sample * add README.md for unix cpp sample * fix example/cpp/unix/README.md * fix README.md * add build-unix-cpp-example workflow * set fail-fast to false * download onnx runtime * mkdir download * remove extra condition * define onnxruntime_lib_name and core_name * fix example/cpp/unix/README.md * trivial change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
example/cpp/unix
ディレクトリに Linux・Mac 向けのサンプルコード (simple_tts.cpp
) を追加します。サンプルのビルド方法は example/cpp/unix/README.md に記載しています。また、Windows 向けのサンプルコード #112 と同様に、サンプルコードがビルドできるかどうかをチェックするCIジョブも追加しています。関連 Issue
VOICEVOX/voicevox_project#1
その他
改善したほうが良い点などありましたらご指摘ください……!