Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows環境でテストエラーになるのを防ぐ処理を追加 #223

Merged

Conversation

qwerty2501
Copy link
Contributor

内容

workaroundが自動化されるのでCIテスト、READMEのworkaround手順を削除

関連 Issue

refs #213, VOICEVOX/onnxruntime-rs#4
経緯については VOICEVOX/onnxruntime-rs#4 を参照

その他

VOICEVOX/onnxruntime-rs#4 がmergeされたのち、CIテストを再実行してからreviewすること

workaroundが自動化されるのでCIテスト、READMEのworkaround手順を削除
@qwerty2501 qwerty2501 force-pushed the feature/resolve-test-error-for-windows branch from eed0b3b to 16b2b66 Compare August 10, 2022 11:19
@qwerty2501
Copy link
Contributor Author

qwerty2501 commented Aug 10, 2022

テスト通るようになりました
Re-Runすれば通ります

@Hiroshiba
Copy link
Member

re run開始しました!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@qwerty2501 qwerty2501 force-pushed the feature/resolve-test-error-for-windows branch from 097c81a to c4ec9b2 Compare August 11, 2022 09:17
Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants