Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onnxruntimeの全てのshared libraryをartifactに含めるようにした #229

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

qwerty2501
Copy link
Contributor

@qwerty2501 qwerty2501 commented Aug 11, 2022

内容

linuxのGPU buildでprovidersが含まれないことがわかったのでshared libraryを全て含めるように変更した

関連 Issue

refs #213 #213 (comment)

@qwerty2501 qwerty2501 force-pushed the feature/add-all-sheared-library branch 2 times, most recently from fd29548 to 507d667 Compare August 11, 2022 04:06
@qwerty2501 qwerty2501 force-pushed the feature/add-all-sheared-library branch from 507d667 to 5744fe9 Compare August 11, 2022 04:06
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Hiroshiba
Copy link
Member

Hiroshiba commented Aug 13, 2022

テストも通ってて問題無さそうなのと、PRのテストが落ちてしまうので、マージします!

@Hiroshiba Hiroshiba merged commit 204d55d into VOICEVOX:main Aug 13, 2022
@qwerty2501 qwerty2501 deleted the feature/add-all-sheared-library branch August 13, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants