Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
macOS の dylib に rpath として
@loader_path/
を追加しました。以前のコメント #203 (comment) で、macOS の dylib について rpath の追加をしなくても良いということを言ったのですが、その後、ビルド済みのエンジンでは問題ないと思われるものの、ビルドしていない状態のエンジンで
--voicelib_dir
オプションでコアの場所を指定するユースケースでは特に rpath を追加した方が良いと感じました。以前の CMake の設定を改めて確認すると
@loader_path/
を rpath として追加していたので、これと同様の設定を行いました。voicevox_core/core/CMakeLists.txt
Lines 104 to 109 in 7ff2e7f
関連 PR
ref #203
その他