Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIドキュメントのリンクを追加 #269

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Sep 10, 2022

内容

READMEに追記しました。

関連issue

close #242

その他

ドキュメントのURLなのですが、とりあえず↓にしてみました。
https://voicevox.github.io/voicevox_core/apis/c_api/globals_func.html

よりわかりやすい一覧ページがあればそちらにしたほうが良いかもです。

@Hiroshiba Hiroshiba temporarily deployed to false September 10, 2022 14:43 Inactive
@Hiroshiba Hiroshiba temporarily deployed to false September 10, 2022 14:43 Inactive
@Hiroshiba Hiroshiba temporarily deployed to false September 10, 2022 14:43 Inactive
@Hiroshiba Hiroshiba temporarily deployed to false September 10, 2022 14:43 Inactive
@Hiroshiba Hiroshiba temporarily deployed to false September 10, 2022 14:43 Inactive
@Hiroshiba Hiroshiba temporarily deployed to false September 10, 2022 14:43 Inactive
@Hiroshiba Hiroshiba temporarily deployed to false September 10, 2022 14:43 Inactive
@Hiroshiba Hiroshiba temporarily deployed to false September 10, 2022 14:43 Inactive
Copy link
Contributor

@qwerty2501 qwerty2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@qryxip qryxip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hiroshiba Hiroshiba merged commit 94f54fd into main Sep 11, 2022
@Hiroshiba Hiroshiba deleted the APIドキュメントへのリンクを追記 branch September 11, 2022 07:57
qryxip added a commit that referenced this pull request Sep 26, 2024
#269 の頃からあるリンクの宛先をvoicevox.github.io/voicevox_core/apis直下
にする。

今後 #496 の話が絡んでくるかもしれない。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APIドキュメントが欲しい
3 participants