Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[project-vvm-async-api] ドキュメントの表記ゆれを解消 #501

Merged
merged 3 commits into from
May 25, 2023
Merged

[project-vvm-async-api] ドキュメントの表記ゆれを解消 #501

merged 3 commits into from
May 25, 2023

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented May 25, 2023 •
edited
Loading

内容

次の表記ゆれを統一します。

  • "VoiceSynthesizer" → "Synthesizer" (Synthesizer/VoicevoxSynthesizerのはずなので)
  • "音声合成モデル" → "音声モデル"

関連 Issue

その他

@qryxip qryxip changed the base branch from main to project-vvm-async-api May 25, 2023 15:27
@qryxip
Copy link
Member Author

qryxip commented May 25, 2023

#493のチェックがちゃんと動いた...
https://github.com/qryxip/voicevox_core/actions/runs/5081762078/jobs/9130578984

Hiroshiba
Hiroshiba approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

@Hiroshiba
Copy link
Member

問題ないと思うのでマージします！

@Hiroshiba Hiroshiba merged commit 14aa242 into VOICEVOX:project-vvm-async-api May 25, 2023
@qryxip qryxip mentioned this pull request May 26, 2023
Merged
67 tasks
@qryxip qryxip mentioned this pull request Jul 22, 2023
Open
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qryxip @Hiroshiba