Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnloadedModel → ModelNotFound #623

Merged
merged 1 commit into from
Sep 25, 2023
Merged

UnloadedModel → ModelNotFound #623

merged 1 commit into from
Sep 25, 2023

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Sep 25, 2023

内容

#622 で宣言した通りSynthesizer::unload_modelが出すUnloadedModelエラーをModelNotFoundに切り替え、UnloadedModelは削除します。

関連 Issue

#580, #589, #600, #622 の続きです。

ref #545

その他

@qryxip qryxip mentioned this pull request Sep 25, 2023
Open
69 tasks
@qryxip qryxip requested a review from Hiroshiba September 25, 2023 14:20
Hiroshiba
Hiroshiba approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！！

@Hiroshiba Hiroshiba merged commit 4fe11f2 into VOICEVOX:main Sep 25, 2023
29 checks passed
@qryxip qryxip mentioned this pull request Sep 28, 2023
Merged
@qryxip qryxip mentioned this pull request Oct 12, 2023
Merged
2 tasks
@qryxip qryxip mentioned this pull request Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevenc-nanashi sevenc-nanashi sevenc-nanashi approved these changes

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qryxip @Hiroshiba @sevenc-nanashi