Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sample.vvmをcrates/test_util/data/model下に構成するようにする #791

Merged
merged 4 commits into from
May 18, 2024
Merged

chore: sample.vvmをcrates/test_util/data/model下に構成するようにする #791

merged 4 commits into from
May 18, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented May 8, 2024

内容

関連 Issue

Resolves #789.

その他

@qryxip qryxip marked this pull request as draft May 8, 2024 19:09
@qryxip qryxip marked this pull request as ready for review May 8, 2024 19:23
@qryxip qryxip requested review from Hiroshiba and sevenc-nanashi May 8, 2024 19:23
@qryxip
Copy link
Member Author

qryxip commented May 9, 2024

#792

@qryxip qryxip requested review from Hiroshiba and removed request for Hiroshiba May 11, 2024 09:17
@qryxip qryxip mentioned this pull request May 12, 2024
Closed
3 tasks
@qryxip
Copy link
Member Author

qryxip commented May 12, 2024

#793 というのを思い付きました。やめた方がよいかもしれませんが、議論しておきたいです。

@qryxip qryxip marked this pull request as draft May 12, 2024 16:41
@Hiroshiba
Copy link
Member

@qryxip #793 は一旦さておき、すでに変更行数が大きいので先にレビュー＆マージしておきたい気持ちがあります･･･！

Hiroshiba
Hiroshiba approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

draftあけてマージしていただければ！！

@qryxip qryxip marked this pull request as ready for review May 18, 2024 01:52
@qryxip
Copy link
Member Author

qryxip commented May 18, 2024

なんか #793 はやめた方がよさそうな気がしました。
#793 (comment)

とりあえずマージします。

@qryxip qryxip merged commit 18aec9f into VOICEVOX:main May 18, 2024
38 checks passed
@qryxip qryxip deleted the chore/unzip-sample-vvm branch May 18, 2024 01:53
@qryxip
Copy link
Member Author

qryxip commented May 18, 2024

@takejohn (#758) 共有です! sample.vvmは、crates/test_utilのビルド後にcrates/test_util/data/model/に作られるようになります。

@qryxip qryxip mentioned this pull request May 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevenc-nanashi sevenc-nanashi sevenc-nanashi approved these changes

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sample.vvmをcrates/test_util/data下に構成するようにする
3 participants
@qryxip @Hiroshiba @sevenc-nanashi