feat!: Synthesizer::audio_queryをcreate_audio_queryに改名
#882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
個人的に腹落ちするまで時間がかかったのですが、上記の二つの理由を見つけることで今PRを出す気になったという次第です。 |
qryxip
force-pushed
the
feat-rename-audio-query-to-create-audio-query
branch
from
1a0f603 to
6b6a771
Compare
qryxip
force-pushed
the
feat-rename-audio-query-to-create-audio-query
branch
from
6b6a771 to
87dd095
Compare
|
ちょっとどういう経緯か覚えてなかったので掘ってました。
|
There was a problem hiding this comment.
Copilot reviewed 5 out of 14 changed files in this pull request and generated no suggestions.
Files not reviewed (9)
- example/python/run.py: Evaluated as low risk
- crates/voicevox_core_java_api/src/synthesizer.rs: Evaluated as low risk
- crates/voicevox_core_python_api/python/test/test_asyncio_user_dict_load.py: Evaluated as low risk
- crates/voicevox_core/src/engine/model.rs: Evaluated as low risk
- crates/voicevox_core_python_api/python/voicevox_core/_models.py: Evaluated as low risk
- crates/voicevox_core_python_api/python/voicevox_core/_rust/blocking.pyi: Evaluated as low risk
- crates/voicevox_core_python_api/python/voicevox_core/_rust/asyncio.pyi: Evaluated as low risk
- docs/guide/user/usage.md: Evaluated as low risk
- crates/voicevox_core_python_api/python/test/test_blocking_user_dict_load.py: Evaluated as low risk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
現状のC APIとJava APIと合わせる形で名前を統一する。理由としては:
create_accent_phrasesとcreate_audio_queryの二つをセットで目立たせることができる関連 Issue
Resolves #700.
その他