Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [release-0.15] remove obsolete parts #896

Open
wants to merge 1 commit into
base: 0.15.5-remove-obsolete-parts
Choose a base branch
from

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Dec 15, 2024

内容

関連 Issue

Refs: #894

その他

@qryxip qryxip mentioned this pull request Dec 15, 2024
@qryxip qryxip requested a review from Hiroshiba December 15, 2024 14:04
@qryxip qryxip changed the title chore: [0.15] remove dead code and an obsolete workaround chore: [0.15] remove obsolete parts Dec 15, 2024
@qryxip qryxip changed the title chore: [0.15] remove obsolete parts chore: [release-0.15] remove obsolete parts Dec 15, 2024
@qryxip
Copy link
Member Author

qryxip commented Dec 15, 2024

なんかCIが以前よりさらに壊れてるような…

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

ですが、release-0.15ブランチを変更するのはちょっと反対です!
VOICEVOX/releaseブランチからVOICEVOX/bufferブランチを作って、そちらをプルリクの宛先にして変更を加える形にしていただけると・・・!

@qryxip qryxip changed the base branch from release-0.15 to 0.15.5-remove-obsolete-parts December 16, 2024 02:19
@qryxip
Copy link
Member Author

qryxip commented Dec 16, 2024

宛先を変えました。

(一度間違えてブランチではなくタグで作ってしまったので、削除しました 🙇)

@Hiroshiba
Copy link
Member

Hiroshiba commented Dec 16, 2024

タグ作って削除した了解です!
こういう操作ログを残しとくの、あとで役に立つことがあるので助かります 🙏

このPRをマージしたあと、VOICEVOX/0.15.5-remove-obsolete-partsqryxip/merge-0.15.5に手元でマージし、qryxip/merge-0.15.5をPRでVOICEVOX/mainにマージする流れでしょうか。

自分が想像してたのはVOICEVOX/release-0.15からVOICEVOX/merge-0.15.5を作ってVOICEVOX/mainをマージし、qryxip:chore-0-15-remove-dead-code-and-an-obsolete-workaroundをPRベースでVOICEVOX/merge-0.15.5にマージしたあと、VOICEVOX/merge-0.15.5をPRでVOICEVOX/mainにマージする流れでした。
頑張ればマージ作業を全部PRででき、かつVOICEVOX/mainをマージしたあとに付け足す形なのでテストが通ることもGithub上でわかるかな~と。

まあでもどちらの流れでも問題はなさそう!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants