整理: Speaker と内部型の分離
#1202
Merged
整理: Speaker と内部型の分離
#1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
May 3, 2024
|
@Hiroshiba |
Hiroshiba
approved these changes
May 5, 2024
|
@Hiroshiba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
整理: VV API
Speaker型と ENGINE 内部型（CoreSpeaker・EngineSpeaker）を分離してリファクタリングした。属性
SpeakerStyleもCoreSpeakerStyleとして分離したため、VV API 話者情報と Core 話者情報は完全に分離された。これによりピッチ範囲情報を任意の箇所（ENGINE or CORE）に実装可能となる。
関連 Issue
ref #1121 (comment)