整理: テスト用のピッチを log スケールに修正 #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要: テスト用のピッチを log スケールに修正してリファクタリング
AudioQuery内のピッチ値は log スケールである。しかしテスト用の値は linear スケールを想定したものになっていた（例:
200）。機能上の問題はないが、より現実的なテスト入力が望ましい。また値が極端に大きいことは round 精度など様々な問題の潜在的原因になりうる。
このような背景から、テスト用のピッチを log スケールに修正するリファクタリングを提案します。
関連 Issue
ref #1297 (comment)