Update: voicevox/voicevoxに追従 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hiroshiba <[email protected]>
* デフォルト出力ファイル名の"..."省略条件の変更 * 0じゃなくて1だった
Co-authored-by: Hiroshiba <[email protected]>
Co-authored-by: Hiroshiba <[email protected]>
Co-authored-by: Nanashi. <[email protected]>
Co-authored-by: Nanashi. <[email protected]>
Co-authored-by: Hiroshiba <[email protected]>
Co-authored-by: Hiroshiba <[email protected]> Co-authored-by: Hiroshiba Kazuyuki <[email protected]>
Co-authored-by: Hiroshiba <[email protected]>
Co-authored-by: Hiroshiba <[email protected]>
Co-authored-by: Hiroshiba <[email protected]>
Co-authored-by: Hiroshiba <[email protected]>
Co-authored-by: Nanashi. <[email protected]>
Co-authored-by: Hiroshiba <[email protected]>
* ドラッグでAudioCellが入れ替えるテストを追加しました * 内容のかぶったテストを削除する ファイル名を変更したときに削除されるべきspecファイルがステージングされてなかったので削除しました * 処理の共通化、コメントの追加をしました
Co-authored-by: Hiroshiba <[email protected]>
Co-authored-by: Hiroshiba <[email protected]>
Co-authored-by: hiroshiba <[email protected]> Co-authored-by: Hiroshiba <[email protected]>
デザイン変更のプルリクエストは小さめだと嬉しい旨をドキュメントに追記
|
あ、これフォワードマージじゃなきゃですね！（スマホなのでメモだけ📝） |
Hiroshiba
approved these changes
Oct 8, 2023
There was a problem hiding this comment.
たぶんLGTM！！
@sevenc-nanashi
そういえばなんですが、以前どこかで議論した（記憶があるけどしてないかも。。）スマホ向けUIをエディターリポジトリに突っ込むのどうですか。
ブラウザ版もできたので、普通のスマホブラウザからも見れるみたいになると面白そうかなと。
（まあ外部エンジンを設定する機能がまだ無いのですが）
|
e2eテストいっぱい落ちてるけど･･･････まあ良いか！！！ |
わりとやりたいですね。追従もやりやすくなりますし。 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
タイトル通り。
また、いつの間にか起動時にクラッシュするようになってたので後で直します。
（Java APIで書いたら解決しそう感はある）
関連 Issue
（なし）
スクリーンショット・動画など
（なし）
その他
（なし）