Add: ユーザー辞書を追加 #40
Merged
Add: ユーザー辞書を追加 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
commented
Nov 15, 2023
Comment on lines
98
to
100
| // Rustのtempfileクレートのための設定。 | ||
| // /data/local/tmp はAndroid 10から書き込めなくなった。そのため、 | ||
| // filesのディレクトリ内に一時フォルダを用意してそこから書き込むように設定する。 |
There was a problem hiding this comment.
ここら辺はあとでCoreにドキュメントPR出します。
| @@ -17,7 +17,7 @@ | |||
| "adjust_intonation_scale": true, | |||
| "adjust_volume_scale": true, | |||
| "interrogative_upspeak": true, | |||
| "synthesis_morphing": true, | |||
| "synthesis_morphing": false, | |||
There was a problem hiding this comment.
これのせいで一部バグっていたので直しました。
| @@ -37,6 +37,8 @@ export type VoicevoxCorePlugin = { | |||
| speakerId: number; | |||
| enableInterrogativeUpspeak: boolean; | |||
| }) => Promise<{ value: string }>; | |||
|
|
|||
| useUserDict: (obj: { wordsJson: string }) => Promise<void>; | |||
There was a problem hiding this comment.
UUIDとかの情報は必要ないので単語だけを毎回渡す形にしています。
Hiroshiba
approved these changes
Nov 15, 2023
Comment on lines
-19
to
+23
| corePlugin.initialize().then(() => { | ||
| (async () => { | ||
| await corePlugin.initialize(); | ||
| await useUserDictWords(corePlugin, await getUserDictWords()); | ||
| isCoreInitialized = true; | ||
| }); | ||
| })(); |
There was a problem hiding this comment.
起動シーケンスに組み込んでちゃんとエンジンが起動してることを保証してあげるようにしたいですね～
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
ユーザー辞書を実装します。
動くことは確認しています（追加ボタンをユーザー辞書ダイアログ表示ボタンにしてテストした）
関連 Issue
スクリーンショット・動画など
（なし）
その他
（なし）