Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate: GitHubの新Markdownに移行 #42

Conversation

sevenc-nanashi
Copy link
Member

内容

参照:https://github.blog/changelog/2023-12-14-new-markdown-extension-alerts-provide-distinctive-styling-for-significant-content/

Importantあたりが良い感じだと思ったのでImportantにしました。

関連 Issue

(なし)

スクリーンショット・動画など

image

その他

「現在開発中です。正常に動かない場合があります。」みたいなテキストにしてもイイかも

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner December 18, 2023 08:41
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team December 18, 2023 08:41
@sevenc-nanashi sevenc-nanashi changed the title Change: GitHubの新Markdownに移行 Migrate: GitHubの新Markdownに移行 Dec 18, 2023
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

綺麗で良い感じですね!

文言は今の形でも十分伝わるだろうなとは思います!
けどよりわかりやすくするのもありだと思います。どちらでもOKだと思うので、マージしていただければ!

@sevenc-nanashi
Copy link
Member Author

まぁマージしちゃいます。

@sevenc-nanashi sevenc-nanashi merged commit 3e5a256 into VOICEVOX:main Dec 18, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants