Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_equal support for fixed_pkg resolve #909 #989

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

abaebae
Copy link
Contributor

@abaebae abaebae commented Feb 23, 2024

How do you want to handle the string representation of fixed_pkg types? I used the to_string function from the fixed_pkg. Do you prefer the to_nibble_string style or a merge of both styles?

@creiter64
Copy link

I'm not an expert in VUnits code, but this looks quite good. About the string representation, I think since fixed_pkg already has one and it's part of the VHDL standard, it should be used.

@umarcor
Copy link
Member

umarcor commented Feb 25, 2024

After updating license copyright years and running black, the remaining CI errors are related to the code in this PR. Check the following format mismatch:

Got:

   logger = check

   log_level = pass

   msg = Equality check passed - Got 1010.0101 (1.03125e1).

   file_name:line_num = :0



expected:

   logger = check

   log_level = pass

   msg = Equality check passed - Got 1010.0101 (10.3125).

   file_name:line_num = :0

Set a format style for `to_string(real)` so that we get a consistent
string format for each simulator. Format now defaults to `"%f"`.
@abaebae
Copy link
Contributor Author

abaebae commented Feb 25, 2024

It seems that every simulator had a slightly different default format for the to_string(real) implementation. The format is now explicitly set to the format string "%f". That should lead to a consistent output style. The format style is up for debate.

@LarsAsplund LarsAsplund merged commit 7c87606 into VUnit:master Mar 10, 2024
14 checks passed
@umarcor
Copy link
Member

umarcor commented Mar 11, 2024

See #997.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants