Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add a little guide to install Vivaldi into Apx #97

Merged
merged 4 commits into from
Nov 3, 2023
Merged

docs: add a little guide to install Vivaldi into Apx #97

merged 4 commits into from
Nov 3, 2023

Conversation

Phosphorus-M
Copy link
Contributor

I did the guide using a Ubuntu Container

@Phosphorus-M
docs: add a little guide to install Vivaldi into Apx
83e84aa 
I did the guide using a Ubuntu Container
kbdharun
kbdharun reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have some suggestions for this page.

_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
@kbdharun kbdharun requested a review from jamiethecat October 26, 2023 17:16
jamiethecat
jamiethecat suggested changes Oct 26, 2023
View reviewed changes
_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
kbdharun
kbdharun reviewed Oct 26, 2023
View reviewed changes
_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
@Phosphorus-M @kbdharun
Apply suggestions from code review
776354a 
Co-authored-by: K.B.Dharun Krishna <[email protected]>
Co-authored-by: Bart Gravendeel <[email protected]>
@Phosphorus-M
Copy link
Contributor Author

Thanks, I updated the PR

jamiethecat
jamiethecat suggested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@jamiethecat jamiethecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done now :)

_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
_posts/2023-10-26-install-vivaldi.md Outdated Show resolved Hide resolved
@Phosphorus-M
Apply suggestions from code review
d5c1a4d 
Co-authored-by: Bart Gravendeel <[email protected]>
@Phosphorus-M
Copy link
Contributor Author

Phosphorus-M commented Oct 29, 2023 •
edited
Loading

Almost done now :)

Could you check now? 🥺 @MonsterObserver

@kbdharun kbdharun added the hacktoberfest-accepted Pull requests that were opened for Hacktoberfest, but may not actually get merged until November. label Oct 31, 2023
@Phosphorus-M
Copy link
Contributor Author

Yeih!

@Phosphorus-M
Copy link
Contributor Author

I can't merge 🥺
Please merge it

@kbdharun kbdharun merged commit a9f3db9 into Vanilla-OS:main Nov 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiethecat jamiethecat jamiethecat approved these changes

@kbdharun kbdharun kbdharun approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Pull requests that were opened for Hacktoberfest, but may not actually get merged until November.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Phosphorus-M @kbdharun @jamiethecat