Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

halt vanilla-installer if non-uefi device is returned #322

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Conversation

Muqtxdir
Copy link
Member

@Muqtxdir Muqtxdir commented Dec 22, 2023

  • renamed FirstSetupApplication to VanillaInstaller
  • added VanillaUnsupported for non-uefi devices.
  • re-used Toggle's asset for VanillaUnsupported

screenshot:

light dark
image image

edit: updated screenshot

- add unsupported window for non-uefi devices.
@Muqtxdir Muqtxdir linked an issue Dec 22, 2023 that may be closed by this pull request
@taukakao
Copy link
Member

I'm still not sure about the wording here.
Telling the user that their device isn't supported although they only have to toggle a setting in their UEFI menu is a bit harsh.
Yes, giving the users instructions is probably a bad idea, since people could run devices that actually don't have a UEFI.

My suggestion would be something like "UEFI must be available and enabled on your device" or something, to signal that the user might be able to fix it.

- change wording for description and title
- align the svg resource with grid scale.
@mirkobrombin mirkobrombin merged commit 72f388e into main Dec 23, 2023
2 checks passed
@mirkobrombin mirkobrombin deleted the feat/319 branch December 23, 2023 20:33
@mirkobrombin
Copy link
Member

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output error if running with legacy BIOS
3 participants