cleanup: add missing rss button & add margin only to the first child #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Till now, all buttons inside the card header were getting a margin of 30px, but that adds a lot of space not nessesary for other than the first button. So I've made the 30px marging only be added to the first child button of the card's header. Sorry for the wall of text, but I wanted to explain exactly why I did this change.
taukakao
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Till now, all buttons inside the card header were getting a top margin of 30px, but that adds a lot of space not necessary for other than the first button. So I've made the 30px top margin only be added to the first child button of the card's header.
Preview
Live Server: https://vos-pr.gxbs.me/download/orchid/stable