Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump VIPCS and WPCS to v3 #2688

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Bump VIPCS and WPCS to v3 #2688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba1e4ba
bump VIPCS and WPCS to v3
tomjn Oct 1, 2023
7a9b73f
added a readme for PHPCS as well as an ignore file for installed files
tomjn Oct 1, 2023
21ef1c3
updated the changelog
tomjn Oct 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ permalink: /docs/en-US/changelog/
### Enhancements

* Switched the default PHP to v8.0 ( #2658 )
* Experimental docker support ( #2632 )
* WP Coding standards v3 ( #2688 )
* VIP Coding standards v3 ( #2688 )

## 3.12 ( 2023 August 3rd )

Expand Down
3 changes: 3 additions & 0 deletions provision/core/phpcs/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
vendor/
bin/
composer.lock
7 changes: 4 additions & 3 deletions provision/core/phpcs/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@
"issues": "https://github.com/Varying-Vagrant-Vagrants/VVV/issues/"
},
"require": {
"dealerdirect/phpcodesniffer-composer-installer": "^0.7.2",
"automattic/vipwpcs": "^2.3.3",
"dealerdirect/phpcodesniffer-composer-installer": "^1.0.0",
"automattic/vipwpcs": "^3",
"phpcompatibility/php-compatibility": "^9.3.5",
"phpcompatibility/phpcompatibility-wp": "^2.1.4"
"phpcompatibility/phpcompatibility-wp": "^2.1.4",
"wp-coding-standards/wpcs": "^3.0.1"
},
"config": {
"allow-plugins": {
Expand Down
8 changes: 8 additions & 0 deletions provision/core/phpcs/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
## VVV PHPCS setup

This folder houses a composer file that installs PHPCS. If PHPCS fails, you can destroy/nuke the vendor and bin folders, as well as the lock file, and re-provision, or even run composer yourself on the host.

The goal for us in terms of packages is to enable both WordPress and VIP coding standards, with PHP compat thrown in for good measure.

Additionally, this is in a shared folder so that you can use the same PHPCS install in your VVV VM as well as your IDE/editor.

Loading