Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for parallels instead of docker #2722

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Check for parallels instead of docker #2722

merged 2 commits into from
Jul 22, 2024

Conversation

tomjn
Copy link
Member

@tomjn tomjn commented Jul 19, 2024

So it turns out if you do:

`command goes here`

And the command doesn't exist, then it will generate a syntax error rather than reporting a failure.

It also turns out that if we use system() to bypass this it works but the output is dumped into the terminal and the only way to avoid it is to pipe to dev/null which isn't an option on Windows.

So instead we ask vagrant if parallels is installed

Checks

  • I've updated the changelog.
  • I've tested this PR
  • This PR is for the develop branch not the stable branch.
  • This PR is complete and ready for review.

Copy link

update-docs bot commented Jul 19, 2024

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@tomjn tomjn requested a review from a team July 19, 2024 19:18
@tomjn tomjn marked this pull request as ready for review July 19, 2024 19:18
@tomjn tomjn added the type:bug label Jul 19, 2024
@tomjn tomjn merged commit 8f4eaaa into develop Jul 22, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant