Added parameter to ignore NPM

[Mte90]

Ref: Varying-Vagrant-Vagrants/VVV#2584

[tomjn]

I wonder if we should also do some UX changes, in particular making npm failure non-blocking, so if npm fails then we can catch and report this to the user and mention the new flags so it isn't a mystery?

Maybe not this but something similar:

npm failed to run, check the site log for output in the provisioner logs folder. You may want to run npm commands on the host and disable npm during provisioning. We'll continue provisioning but some things may not work.

[tomjn]

Perhaps separate flags for grunt and npm?

[Mte90]

Grunt packages are in the same package.json file so it isn't possible to install just them.

[Mte90]

I wonder if we should also do some UX changes, in particular making npm failure non-blocking, so if npm fails then we can catch and report this to the user and mention the new flags so it isn't a mystery?

I don't know if it is easy to track NPM errors or if return a specific exit code

[Mte90]

I see also another issue in the tests config file that is not filled with the VVV data.
I will update this PR.

Also is missing to run composer to install phpunit etc

[tomjn]

True but I was referring to running the grunt build

…

On Wed, 9 Mar 2022 at 14:00, Daniele Scasciafratte ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In provision/vvv-init.sh <#32 (comment)> : > +if [[ "${NPM}" == "true" ]]; then + try_npm_install + try_grunt_build +fi Grunt packages are in the same package.json file so it isn't possible to install just them. — Reply to this email directly, view it on GitHub <#32 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAOLZ23JM2YD7WATQSHENDU7CVIJANCNFSM5QHBCZGQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because your review was requested.Message ID: <Varying-Vagrant-Vagrants/custom-site-template-develop/pull/32/review/904400326 @github.com>

[tomjn]

Just did the npm commands return a good or a bad code, we don’t need to be any more specific than that

…

On Wed, 9 Mar 2022 at 14:03, Daniele Scasciafratte ***@***.***> wrote: I wonder if we should also do some UX changes, in particular making npm failure non-blocking, so if npm fails then we can catch and report this to the user and mention the new flags so it isn't a mystery? I don't know if it is easy to track NPM errors or if return a specific exit code — Reply to this email directly, view it on GitHub <#32 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAOLZZ4VOKAFB2ZGEG2FIDU7CVRPANCNFSM5QHBCZGQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because your review was requested.Message ID: <Varying-Vagrant-Vagrants/custom-site-template-develop/pull/32/c1062952118 @github.com>

[Mte90]

You are right, I checked now the code and I saw that grunt was executed twice in the provision.
The last commit should fix everything, I am testing it.

[Mte90]

@tomjn can you check now this pr?