Tom draal adv chem

[TomDraal]

Hi,
I've made some changes in order to add some more advanced settings on the Chemical Warfare in H&M.
The idea is to enable chemical warfare and choose if the chemical side missions will spawn or not and also set a chance probability of having a chemical weapons cache or not.

• Add: advanced settings on chemical warfare (@TomDraal).

When merged this pull request will:

• Allow the user to choose if he/she wants to have chemical side missions while chemical warfare is enabled
• Tweak the chance probability (%age) of having a chemical weapons cache

Final test:

• local
• server

[Vdauphin]

Hello,

Thank you for your contribution
We need to be consistent between setting
Before: btc_p_chem ON, side mission and chemical were enabled
Now, if btc_p_chem ON but btc_p_chem_sides and btc_p_chem_cache_probability are OFF, nothing will happen

Despite, I don't really see the point of having a setting for side mission as they can be skipped by the Officer I would recommend to

• add the existing setting btc_p_chem: Off, On without weapon cache, On without side mission, On with both
• create a btc_p_chem_cache_probability as you did without the 0%

Cheers

[TomDraal]

Hello,
We want to be able to deactivate the chemical side missions because sometimes while using the skip feature some contaminated elements remains. At least we had some bad surprises in the past, so deactivating the chemical side missions is the safest way.
If you want full consistency then the best way is to completely remove btc_p_chem which I saw like a general switch on / off.
So I wanted to keep it just in case someone would want to add other chemical warfare related tasks.
By only keeping btc_p_chem_sides and btc_p_chem_cache_probability with a 0-100% range, we will have the behaviour you described :

• sides ON and cache OFF (0%)
• sides OFF and cache ON (>0%)
• sides OFF and cache OFF (0%) => equivalent to btc_p_chem OFF
• sides ON and cache ON (>0%) => equivalent to btc_p_chem ON

Would that suits you ?
Cheers

[Vdauphin]

If you want full consistency then the best way is to completely remove btc_p_chem which I saw like a general switch on / off.

I thought about it but I think it would be simpler to use number instead of bool for btc_p_chem (just do btc_p_chem > 0 where needed)
It is up to you to make a choice on this!