Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Convert MinimalBatchExecutor to 7579 style #1170

Merged
merged 10 commits into from
Nov 21, 2024
Merged

♻️ Convert MinimalBatchExecutor to 7579 style #1170

merged 10 commits into from
Nov 21, 2024

Conversation

Vectorized
Copy link
Owner

Description

Hmm... I'm not very convinced.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@Vectorized Vectorized changed the base branch from new-erc-tidy to main November 21, 2024 10:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

Gas Snapshot Comparison Report

Generated at commit : 44d5719, Compared to commit : c39ad46

Contract Name Test Name Main Gas PR Gas Diff
MinimalBatchExecutorTest testMinimalBatchExecutor() 43532 - -
testMinimalBatchExecutorForRevert() 17472 43728 26256
test__codesize() 7673 10073 2400
testMinimalBatchExecutorGas() - 42138 -

@Vectorized Vectorized merged commit 9185d1f into main Nov 21, 2024
11 checks passed
@Vectorized Vectorized deleted the new-erc-convert-to-7579 branch November 21, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vectorized