Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RCA PlayingMode #25

Merged

Conversation

berezovskyi-oleksandr
Copy link
Contributor

@berezovskyi-oleksandr berezovskyi-oleksandr commented Aug 9, 2024

I have Triangle AIO Twin speakers, which report "plm_support": "0x36". I observed that bit 5 (32) is not mentioned in any LinkPlay documents I have found so far

On the other hand, the mode field in the getPlayerStatus API call output shows 0x44, once the speakers are set up to the RCA output. The setPlayerCmd:switchmode:RCA API call works correctly.

UPD: I decompiled the Triangle's Android app and found the following bit mapping:

2: Line-In
4: Bluetooth
8: USB
16: Optical
32: RCA
64: Coaxial
128: Radio
256: Line-In 2
512: XLR
1024: HDMI
2048: CD
4096: TF Card

@dukeofphilberg
Copy link
Contributor

Great! Thank you so much.

On the other hand, the mode field in the getPlayerStatus API call output shows 0x44, once the speakers are set up to the RCA output. The setPlayerCmd:switchmode:RCA API call works correctly.

This is already mapped in the PlayingMode enum under RCA = "44" which seems to check out.

UPD: I decompiled the Triangle's Android app and found the following bit mapping:

2: Line-In
4: Bluetooth
8: USB
16: Optical
32: RCA
64: Coaxial
128: Radio
256: Line-In 2
512: XLR
1024: HDMI
2048: CD
4096: TF Card

Good info! I think we could do a lot with decompiling some apps and see the correct modes. I will add these in a seperate PR.

@dukeofphilberg dukeofphilberg self-requested a review August 9, 2024 11:35
@dukeofphilberg dukeofphilberg merged commit 578a2cc into Velleman:main Aug 9, 2024
3 checks passed
@berezovskyi-oleksandr berezovskyi-oleksandr deleted the feat/rca-playingmode branch August 9, 2024 12:25
@berezovskyi-oleksandr
Copy link
Contributor Author

berezovskyi-oleksandr commented Aug 9, 2024

@dukeofphilberg small update
TF Card is not 4096, but 8192 (bit 13)

4096 (bit 12) is not checked in the app

@dukeofphilberg
Copy link
Contributor

@dukeofphilberg small update TF Card is not 4096, but 8192 (bit 13)

4096 (bit 12) is not checked in the app

Thanks for the update, I've edited it in a local branch that will ,include it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants