Allow embedded config to come from an external file #2899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On MacOS we can not modify the binary after build due to hashes and verifications. This PR allows the embedded config to be written to a stub file (shell script) which can be used later to bootstrap the offline collector. This approach is a bit more complicated but will also be useful on Windows where the repack operation invalidates the signature. We can still use this same approach on Windows too without needing to resign the binary.
scudette
added a commit
to scudette/velociraptor
that referenced
this pull request
Aug 28, 2023
On MacOS we can not modify the binary after build due to hashes and verifications. This PR allows the embedded config to be written to a stub file (shell script) which can be used later to bootstrap the offline collector. This approach is a bit more complicated but will also be useful on Windows where the repack operation invalidates the signature. We can still use this same approach on Windows too without needing to resign the binary.
scudette
added a commit
that referenced
this pull request
Aug 28, 2023
On MacOS we can not modify the binary after build due to hashes and verifications. This PR allows the embedded config to be written to a stub file (shell script) which can be used later to bootstrap the offline collector. This approach is a bit more complicated but will also be useful on Windows where the repack operation invalidates the signature. We can still use this same approach on Windows too without needing to resign the binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacOS we can not modify the binary after build due to hashes and verifications. This PR allows the embedded config to be written to a stub file (shell script) which can be used later to bootstrap the offline collector.
This approach is a bit more complicated but will also be useful on Windows where the repack operation invalidates the signature. We can still use this same approach on Windows too without needing to resign the binary.