Disable compatibility with URL style paths #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the distant past we used to use url encoding to encode recursive pathspecs but this is problematic because url encoding is just not reliable enough. We have since moved to an OSPath object that properly encodes paths as JSON objects but there is still some backwards compatibility code in there that tries to detect a URL style path by looking for # (the fragment component of the url). This is probably a good time to remove this compatibility code because we dont use urls for probably about 4-5 releases now. Fixes: #2906
scudette
added a commit
to scudette/velociraptor
that referenced
this pull request
Aug 28, 2023
In the distant past we used to use url encoding to encode recursive pathspecs but this is problematic because url encoding is just not reliable enough. We have since moved to an OSPath object that properly encodes paths as JSON objects but there is still some backwards compatibility code in there that tries to detect a URL style path by looking for # (the fragment component of the url). This is probably a good time to remove this compatibility code because we dont use urls for probably about 4-5 releases now. Also sync latest KapeFiles Targets and fixed tests Fixes: Velocidex#2906
scudette
added a commit
that referenced
this pull request
Aug 28, 2023
In the distant past we used to use url encoding to encode recursive pathspecs but this is problematic because url encoding is just not reliable enough. We have since moved to an OSPath object that properly encodes paths as JSON objects but there is still some backwards compatibility code in there that tries to detect a URL style path by looking for # (the fragment component of the url). This is probably a good time to remove this compatibility code because we dont use urls for probably about 4-5 releases now. Also sync latest KapeFiles Targets and fixed tests Fixes: #2906
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the distant past we used to use url encoding to encode recursive pathspecs but this is problematic because url encoding is just not reliable enough. We have since moved to an OSPath object that properly encodes paths as JSON objects but there is still some backwards compatibility code in there that tries to detect a URL style path by looking for # (the fragment component of the url).
This is probably a good time to remove this compatibility code because we dont use urls for probably about 4-5 releases now.
Also sync latest KapeFiles Targets and fixed tests
Fixes: #2906