Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a generic hostsfile artifact #2930

Merged
merged 7 commits into from
Sep 9, 2023
Merged

Add a generic hostsfile artifact #2930

merged 7 commits into from
Sep 9, 2023

Commits on Sep 8, 2023

  1. Add a hostsfile artifact for all three OSes

    @misje @scudette
    misje authored and scudette committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    8beda88 View commit details
    Browse the repository at this point in the history

  2. Add full-line comments to test file to better test regex

    @misje @scudette
    misje authored and scudette committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    3d1f1ac View commit details
    Browse the repository at this point in the history

  3. Rename artifact name in test to new Generic.HostsFile

    @misje @scudette
    misje authored and scudette committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    b470128 View commit details
    Browse the repository at this point in the history

  4. Added tests and refactor 

    Also added a README to describe how to run the golden tests.
    @scudette
    scudette committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    fb6735a View commit details
    Browse the repository at this point in the history

  5. Fix test

    @scudette
    scudette committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    a8cee65 View commit details
    Browse the repository at this point in the history

  6. Fix regex

    @scudette
    scudette committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    da63513 View commit details
    Browse the repository at this point in the history

  7. Refactored parser to use parse_string_with_regex

    @scudette
    scudette committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    e1c850a View commit details
    Browse the repository at this point in the history