Merge pull request #117 from Venafi/Cloud-ping_issue

Fix VCertClient.ping() for Cloud is not working. The Ping capability is not longer provided by VaaS so this ping method has been deprecated
Venafi · Sep 1, 2022 · 41bde09 · 41bde09
2 parents 8981df6 + 20fc0ce
commit 41bde09
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 14 deletions.
diff --git a/src/main/java/com/venafi/vcert/sdk/connectors/cloud/Cloud.java b/src/main/java/com/venafi/vcert/sdk/connectors/cloud/Cloud.java
@@ -66,10 +66,6 @@ Response retrieveCertificate(@Param("id") String id, @Param("apiKey") String api
   @RequestLine("GET /outagedetection/v1/certificates/{id}")
   CertificateDetails certificateDetails(@Param("id") String id, @Param("apiKey") String apiKey);
 
-  @RequestLine("GET ping")
-  @Headers("x-venafi-api-key: {apiKey}")
-  Response ping(@Param("apiKey") String apiKey);
-
   @RequestLine("GET /v1/certificateauthorities/{CA}/accounts")
   @Headers("tppl-api-key: {apiKey}")
   CAAccountsList getCAAccounts(@Param("CA") String caName, @Param("apiKey") String apiKey);

diff --git a/src/main/java/com/venafi/vcert/sdk/connectors/cloud/CloudConnector.java b/src/main/java/com/venafi/vcert/sdk/connectors/cloud/CloudConnector.java
@@ -104,17 +104,12 @@ public String getVendorAndProductName() {
     return vendorAndProductName;
   }
 
+  /**
+   * @deprecated The ping capability is not longer supported by VaaS.
+   */
   @Override
-  public void ping() throws VCertException {
-    Response response = doPing();
-    if (response.status() != 200) {
-      throw new CloudPingException( response.status(), response.reason());
-    }
-  }
-
-  private Response doPing() {
-    return cloud.ping(credentials.apiKey());
-  }
+  @Deprecated
+  public void ping() throws VCertException {}
 
   /**
    * {@inheritDoc}