Skip to content

Commit

Permalink
Fix Github Actions
Browse files Browse the repository at this point in the history
This commit fixes Github Actions by:

* Updating Node version from 12 to 14.

* Updating GHA runner images from Ubuntu 18.04 to 20.04.

* Moving from `manylinux_2_24_x86_64` container image to
  `node:14-buster`.

* Updating C++ version used by MacOS compilation to 17.
  • Loading branch information
jeffesquivels committed Aug 16, 2023
1 parent 47d3180 commit 65af5bf
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 10 deletions.
17 changes: 9 additions & 8 deletions .github/workflows/prebuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v2
with:
node-version: 12
node-version: 14
- run: npm install
- run: npm test
- run: npm run prebuild
Expand All @@ -25,15 +25,16 @@ jobs:
files: prebuild-darwin.tar
build-linux:
if: startsWith(github.ref, 'refs/tags/')
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
container: quay.io/pypa/manylinux2014_x86_64
steps:
- run: ldd --version ldd
- uses: actions/checkout@v2
- name: Setup node
uses: actions/setup-node@v2
with:
node-version: 12
node-version: 14
- run: yum install -y python3
- run: npm install
- run: npm run prebuild
- run: npm test
Expand All @@ -44,8 +45,8 @@ jobs:
with:
files: prebuild-linux.tar
build-alpine:
runs-on: ubuntu-18.04
container: node:12.22-alpine
runs-on: ubuntu-20.04
container: node:14.21-alpine
steps:
- run: apk add python3 py3-pip build-base
- uses: actions/checkout@v2
Expand All @@ -60,8 +61,8 @@ jobs:
files: prebuild-alpine.tar
build-linux-arm64:
if: startsWith(github.ref, 'refs/tags/')
runs-on: ubuntu-18.04
container: quay.io/pypa/manylinux_2_24_x86_64
runs-on: ubuntu-20.04
container: node:14-buster
steps:
- run: apt-get update
- run: apt-get install -y gcc-aarch64-linux-gnu
Expand All @@ -71,7 +72,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v2
with:
node-version: 12
node-version: 14
- run: npm install
- run: npm run prebuild-arm64
if: startsWith(github.ref, 'refs/tags/')
Expand Down
4 changes: 2 additions & 2 deletions binding.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@
}]
],
"xcode_settings": {
"OTHER_CPLUSPLUSFLAGS" : ["-std=c++14"],
"OTHER_CPLUSPLUSFLAGS" : ["-std=c++17"],
"MACOSX_DEPLOYMENT_TARGET": "10.7",
"OTHER_LDFLAGS": ["-std=c++14"],
"OTHER_LDFLAGS": ["-std=c++17"],
"CLANG_CXX_LIBRARY": "libc++"
}
}],
Expand Down

0 comments on commit 65af5bf

Please sign in to comment.