[VAN-503] Convert to/from i1 as needed #47
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic functions (
fr_logic_*
), the library functions (like constraints and assertions), and branch instructions requirei1
(i.e., boolean) arguments. So, when storing the results of logic operations to a regular variable (which is always a bigint, i.e.i256
) or implicitly converting a regular variable into a boolean (e.g.,if (foo)
), a conversion needs to occur in the LLVM IR. I've implemented the following changes:val != 0
).I also added 4 test cases (3 from the original issue, one that I added during debugging).