[VAN-753] Change GEP style for array constraints #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-hoffman
reviewed
Oct 17, 2023
| @@ -860,3 +860,18 @@ pub fn create_switch<'a>( | |||
| ) -> InstructionValue<'a> { | |||
| producer.builder().build_switch(value, else_block, cases) | |||
| } | |||
|
|
|||
| pub fn get_index_from_gep(gep: PointerValue) -> usize { | |||
| let op = gep | |||
There was a problem hiding this comment.
Maybe it should assert that gep has the GEP opcode.
There was a problem hiding this comment.
Maybe also assert that operand 1 is 0?
There was a problem hiding this comment.
Putting a 0 as the first argument of a gep seems to be the standard, I would not worry too much about that, but Im adding the opcode check
There was a problem hiding this comment.
That's exactly why I would add the assert. If some weird case ever appeared where it wasn't 0 for some reason, we would want to know.
|
Looking at the failing test case I think this may not work with subcomponent signals but Im not sure yet |
|
Yeah, I'm creating GEPs from %0 when one of them should be from %6 (in this case) |
0xddom
deleted the
dani/VAN-753-Change-GEP-style-for-constraint-signals-when-generating-array-constraints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.