Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Circuit monad] Shared context #32

Merged
merged 2 commits into from
Dec 18, 2024
Merged

[Circuit monad] Shared context #32

merged 2 commits into from
Dec 18, 2024

Conversation

mitschabaude
Copy link
Collaborator

@mitschabaude mitschabaude commented Dec 17, 2024

Instead of instantiating subcircuits with a new Context F -- which determines the numbering of variables --, we pass the current context down to subcircuits

Thanks to this, in the final list of constraints we now have distinct indices for distinct vars, which seems important

Base automatically changed from eval-env-soundness to main December 17, 2024 19:44
@mitschabaude mitschabaude marked this pull request as ready for review December 17, 2024 20:01
Copy link
Collaborator

@gio54321 gio54321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
I agree, this is a cleaner way to structure things and does not change much the proofs

@mitschabaude mitschabaude merged commit 03dba76 into main Dec 18, 2024
1 check passed
@mitschabaude mitschabaude deleted the continuous-context branch December 18, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants