update error message to align with playwright-go update

[charlottecampbell193]

New version of playwright-go 'run.go' file added a check on if the driver is up to date. Updated TestNoBrowserDriverFail in browser_test.go to look for the new error message.

	driver, err := NewDriver(transformRunOptions(options))
	if err != nil {
		return nil, fmt.Errorf("could not get driver instance: %w", err)
	}
	**up2date, err := driver.isUpToDateDriver()
	if err != nil || !up2date {
		return nil, fmt.Errorf("please install the driver (v%s) and browsers first: %w", playwrightCliVersion, err)
	}**

[mapkon]

Minor clarification comment

[mapkon]

Thank you for this change @charlottecampbell193 - is there a scenario where the error "could not start driver" will be thrown? Or has that been completely removed?

[charlottecampbell193]

@mapkon that error can still be thrown but not with the current test. A new test would need to be created that has the correct driver installed but has some other issue that is preventing it from starting. I'm not sure what scenario that would be though.

[mapkon]

You are right since the current error message is probably faulty, and playwright has fixed their API. The current test was exercising the scenario where there is completely no driver, so it makes sense to throw the please install the driver message. The comment on the test gave it away:
// Test that if download directory does not have browsers, it fails with expected error message

I imagine that we should have a test that launches a directory with an existing driver that we know won't "start", and see if that will fire it up (probably an invalid browser binary or similar). I wouldn't spend more than a day on it if you cannot get it to start.

Lastly, remember to update the README on line 575 to reflect the new message that will get thrown if the user attempts use without installing the drivers (like on first time use).

[charlottecampbell193]

I was not able to recreate that error message. When I had an invalid browser binary the error I got was 'playwright: spawn UNKNOWN'. Tried a bunch of stuff messing around with it and got many other unhelpful messages but not could not start driver.

README has been updated - let me know your thoughts on the update.

[mapkon]

Suffices for me. We can merge it now or wait for #1302 to be fixed (so we can run all the tests). Let me know

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.19%. Comparing base (99d6fe4) to head (ed387cc).
Report is 14 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1299   +/-   ##
=======================================
  Coverage   42.19%   42.19%           
=======================================
  Files          54       54           
  Lines        6456     6456           
=======================================
  Hits         2724     2724           
  Misses       3283     3283           
  Partials      449      449           

Flag	Coverage Δ
unittests	42.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.