This repository has been archived by the owner on Dec 20, 2022. It is now read-only.
refactor: standardize fractal I/II & II/II #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the motivation for standardizing fractal is to reduce boilerplate increase mindshare and lower the effort to contribute for std users. std users will likely become very active users of and contributors to fractal in the near future.
blaggacao
force-pushed
the
refactor-stdize-1
branch
from
77389b5
to
56eb83c
Compare
blaggacao
changed the title
blaggacao
commented
Dec 11, 2022
| ["lib" "validators"] | ||
| ["ext" "hooks"] | ||
| ["ext" "flux"] | ||
| ]; |
There was a problem hiding this comment.
We also have an actual improvement: This is not limited to x86_64-linux anymore so mac users can use it.
I checked xnlib only depends on system for ansi colors, so the code paths used herein are unaffected by xnlib's hardcoding of system.
blaggacao
commented
Dec 11, 2022
ext/hooks.nix
Outdated
Comment on lines
5
to
16
| transformer = config: resource: | ||
| if config.cluster.renderer.mode == "flux" | ||
| # consume the flux tranformer default for CRDs | ||
| then cell.flux.transformer {inherit config;} null null resource | ||
| else resource; | ||
|
|
||
| builder = config: [] ++ ( | ||
| optional (config.cluster.renderer.mode == "flux") | ||
| (cell.flux.buildLayerKustomizations config) | ||
| ); |
There was a problem hiding this comment.
I also took the liberty to cleanup complex mutual nesting with mutual function callbacks and consolidate extensions into this hook integration file.
There was a problem hiding this comment.
i.e. lib should know nothing about the details of ext, ext should only consume a very limited set of contracts from lib.
blaggacao
force-pushed
the
refactor-stdize-1
branch
2 times, most recently
from
6119ac8
to
0c62f94
Compare
blaggacao
force-pushed
the
refactor-stdize-1
branch
2 times, most recently
from
f5f582c
to
31ed5d6
Compare
blaggacao
force-pushed
the
refactor-stdize-1
branch
2 times, most recently
from
43cc03a
to
daee51e
Compare
blaggacao
force-pushed
the
refactor-stdize-1
branch
from
daee51e
to
bd23d72
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the motivation for standardizing fractal is to reduce boilerplate
increase mindshare and lower the effort to contribute for std users.
std users will likely become very active users of and contributors
to fractal in the near future.