Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote service builder #35

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ruzkant
Copy link

@ruzkant ruzkant commented Jan 18, 2020

This is a proposal to support the goals of issue #28, but an alternative approach to the RpcRequestBuilder from GWT 2. It follows the same pattern as the websocket ServerBuilder.

@ruzkant
Copy link
Author

ruzkant commented Jan 18, 2020

Neither the old factory nor ServiceDefTarget have been removed as yet.

One can keep ServiceDefTarget by adding the following to allow the url from service def target to be used, but support overriding it with the url from the builder. This makes it possible to add the old @RemoteServiceRelativePath annotation so the service would know the url from there (which is how I think GWT 2 works.

    String url = "";
    if (instance[0] instanceof ServiceDefTarget) {
        url = ((ServiceDefTarget) instance[0]).getServiceEntryPoint();
    }
    if(getUrl() != null) {
        url = getUrl();
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant