User jakarta @Generated annotations #58
Conversation
| @@ -45,7 +45,7 @@ public class Processor extends AbstractProcessor { | |||
| private static final String knownTypesFilename = "knownTypes.txt"; | |||
|
|
|||
| private static final String GENERATED_ANNOTATION_JDK9 = "javax.annotation.processing.Generated"; | |||
| private static final String GENERATED_ANNOTATION_LEGACY = "javax.annotation.Generated"; | |||
There was a problem hiding this comment.
I'm not necessarily opposed to this, but given how this is consumed (addGeneratedMetadata, about line 746), shouldnt it be a new annotation, so we can ask "do you have A, B, or C" and use the first that is available?
That is, introduce a new constant, and add it to the stream to be checked. I've confirmed that the javax.annotation.processing.Generated support in GWT works now, and can be restored.
There was a problem hiding this comment.
yes, I was thinking the same thing. Even something as simple as System.getProperty("generated.annotation", "javax.annotation.Generated") would be nice. Certainly possible to somehow skim the "classpath" / codegen environment to find types, but if there was more than one match, you'd probably want the system property anyway to decide, so unlikely to be worth the effort.
There was a problem hiding this comment.
Basically, this was "I did this for internal changes using this code", knowing it wasn't suitable to merge (my bad for not explaining that). I defer to you on what solution you think is most maintainable. Keeping the default gwt compatible is obviously best. I did not have any issues building dh js api locally w/ this change, so jakarta is probably fine too. It has SOURCE retention, so I think that means gwt only needs the annotation class and not the source, no?
This may not even be necessary, just what I did locally while working on jetty upgrade