Attestations V2 #23

monkins1010 · 2024-01-31T08:30:32Z

No description provided.

michaeltout

Thank you for the PR. I've been busy so unfortunately has taken a while to get to it, but the PR is overall moving in a good direction. Still requires changes, as noted in the inline comments. Let me know if anything is unclear or you have any questions.

michaeltout · 2024-07-14T17:14:10Z

src/__tests__/attestation/attestation.test.ts

Please run through a code formatter to fix inconsistent spacing

These are not actual tests, they lack the expect() function so they don't have any failure condition except an error being thrown

The names for these tests do not describe what they are doing, e.g. the "request profile information" test doesn't actually request profile information, it creates a profile information request (when fixed it should probably be '(de)serialises a profile information request')

Please follow the conventions of other tests and test that serialisation/deserialisation occurs successfully (i.e. a serialised object can be deserialised and remain the same, see other tests)

Please remove the commented code or complete what it is a TODO for

michaeltout · 2024-07-14T17:18:30Z

src/__tests__/attestation/personalInfo.test.ts

+import { SignatureData } from "../../vdxf/classes/SignatureData";
+
+describe('Create a personal info request', () => {
+  test('serialize datadescriptor with nested datadescriptor', async () => {


This test doesn't actually test for serialisation working as expected. Instead, it just tests for a serialised data descriptor matching some hardcoded value. Please change this to match the structure of previous serialisation tests where a data descriptor is serialised, deserialised, re-serialised, and then matched against a separate instance of the data descriptor that should contain the same data (see other tests). Feel free to reach out if this is unclear.

The goal should be to avoid hardcoding expected values where able, its mostly done in other tests only in cases where those values can only be obtained from the daemon.

michaeltout · 2024-07-14T17:19:06Z

src/__tests__/attestation/personalInfo.test.ts

+
+  });
+
+  test('serialize mmrdescriptor', async () => {


This test has the same issue described above.

michaeltout · 2024-07-14T17:19:24Z

src/__tests__/attestation/personalInfo.test.ts

+
+  });
+
+  test('serialize mmrdescriptor', async () => {


This test has the same issue described above.

michaeltout · 2024-07-14T17:19:28Z

src/__tests__/attestation/personalInfo.test.ts

+    expect(mmrbuffer).toStrictEqual("01050101002030395e0868b1953477e14bb5c16349622239a94115a4d1f02b72b6ecf8b1c79c01005741d826d3c6cbbc3a96992670d2f604e959fd1a8c014102f1eac8f180bee7fb256b801b219e20612fbc9f5e99da111a8364d1197ff3e3fbef8259770f618dacee9489e8cd2cd5dd77d36ede6c42cebdabd85a5b5e8af60b0201024c08a2ebb2c55f83a8e2a426a53320ed4d42124f4d013601600543687269732269344771736f7448476134637a436474673264384656484b664a467a56794250724d0a746578742f706c61696e204f66603f256d3f757b6dc3ea44802d4041d2a1901e06005028fd60b85a5878a201024e08a2ebb2c55f83a8e2a426a53320ed4d42124f4d01380160074d6f6e6b696e73226948796254724e42316b5852726a7343744a5864366676424b786570714d7053355a0a746578742f706c61696e2062fae0c46b2ad1177749e25fd6d48ccb40213d3cc72e4b2b0dc533039cbe8314");
+
+  });
+  test('serialize mmrdescriptor', async () => {


This test has the same issue described above.

michaeltout · 2024-07-15T18:09:47Z

src/vdxf/vdxfDataKeys.ts

Please space consistently, separating exports and keeping line indents standardized with the rest of the codebase

Why are these functions as opposed to constants? We can discuss this, not opposed just wondering why

This filename should be all lowercase to match the rest of the codebase

michaeltout · 2024-07-15T18:13:30Z

src/vdxf/keymap.ts

Please keep capitalisation on exports consistent

Please space export as they are spaced in the rest of the codebase for readability

michaeltout · 2024-07-15T18:26:35Z

src/vdxf/scopes.ts

+  qualifiedname: {
+    namespace: "i5w5MuNik5NtLcYmNzcvaoixooEebB6MGV",
+    name: "vrsc::profile.data.view"


Should this have the identity prefix? Idk for sure, we can discuss

To discuss maybe

vrsc::identity.profile.proposed.data.view
not sure, your basically asking if you can see your PII data that's in the mobile app

michaeltout · 2024-07-15T18:51:40Z

src/vdxf/keys.ts

See note above regarding bounddata

michaeltout · 2024-07-15T18:54:17Z

package.json

@@ -1,6 +1,6 @@
 {
  "name": "verus-typescript-primitives",
-  "version": "1.0.0",
+  "version": "1.0.1",


Don't worry about changing the version in the PR, I'll rebase the PR into a new branch and change the version when it goes to master

monkins1010 · 2024-10-02T15:38:21Z

When we do toJson and fromJson in classes these are not compatible with the data coming out of the daemon, how do we handle for when you e.g.
make an object to be signed, put it into the daemon, the daemon returns a json object. we want to capture that object into javascript, the json is incompatible for exmple:

 static fromJson(data: TransferDestinationJson): TransferDestination {
   return new TransferDestination({
     type: new BN(data.type),
     destination_bytes: Buffer.from(data.destination_bytes, 'hex'),
     gateway_id: data.gateway_id,
     gateway_code: data.gateway_code,
     fees: new BN(data.fees),
     aux_dests: data.aux_dests.map(x => TransferDestination.fromJson(x))
   })
 }```

monkins1010 · 2024-10-02T15:48:58Z

When we do toJson and fromJson in classes these are not compatible with the data coming out of the daemon, how do we handle for when you e.g. make an object to be signed, put it into the daemon, the daemon returns a json object. we want to capture that object into javascript, the json is incompatible for exmple:
 static fromJson(data: TransferDestinationJson): TransferDestination {
   return new TransferDestination({
     type: new BN(data.type),
     destination_bytes: Buffer.from(data.destination_bytes, 'hex'),
     gateway_id: data.gateway_id,
     gateway_code: data.gateway_code,
     fees: new BN(data.fees),
     aux_dests: data.aux_dests.map(x => TransferDestination.fromJson(x))
   })
 }```

Do we make for example a fromDaemonJson() and toDaemonJson() for each object?

monkins1010 · 2024-10-03T06:32:28Z

When we do toJson and fromJson in classes these are not compatible with the data coming out of the daemon, how do we handle for when you e.g. make an object to be signed, put it into the daemon, the daemon returns a json object. we want to capture that object into javascript, the json is incompatible for exmple:
 static fromJson(data: TransferDestinationJson): TransferDestination {
   return new TransferDestination({
     type: new BN(data.type),
     destination_bytes: Buffer.from(data.destination_bytes, 'hex'),
     gateway_id: data.gateway_id,
     gateway_code: data.gateway_code,
     fees: new BN(data.fees),
     aux_dests: data.aux_dests.map(x => TransferDestination.fromJson(x))
   })
 }```
Do we make for example a fromDaemonJson() and toDaemonJson() for each object?

I've made all the new PBaaS Classes are compatible with the daemon

michaeltout

Thanks for the changes! Looking good, things are coming along well, most issues concern either something we discussed on the phone, adding tests for certain components, or minor naming/style changes.

michaeltout · 2024-10-03T12:15:48Z

src/api/ApiPrimitive.ts

@@ -15,7 +16,8 @@ export type ApiPrimitive =
  | Array<ApiPrimitive>
  | IdentityDefinition
  | BlockInfo
-  | RawTransaction;
+  | RawTransaction
+  | signDataArgs;


I don't understand why this is necessary, I think everything in signDataArgs is already covered here. I deleted this like and it still builds and seems to function as expected. If this causes problems in verusd-rpc-ts-client its fine to include it here though, just capitalize the first letter to keep with convention, and make it an interface instead of a type if it can be one.

michaeltout · 2024-10-03T12:16:22Z

src/api/classes/SignData/SignDataRequest.ts

+import { DataDescriptor } from "../../../utils/types/DataDescriptor";
+import { SignData } from "../../../utils/types/SignData";
+
+export type signDataArgs = {


Exported types typically start with a capital letter.

michaeltout · 2024-10-03T12:19:02Z

src/api/classes/SignData/SignDataResponse.ts

+import { DataDescriptor } from "../../../utils/types/DataDescriptor";
+
+export class SignDataResponse extends ApiResponse {
+  result: {


Many of these are optional as a response from signdata, best to mark those with a ?. I've been burned before because I forgot this on some other APIs (I think some still have this issue).

michaeltout · 2024-10-03T12:24:30Z

src/pbaas/ContentMultiMapRemove.ts

This component is not represented in any test file, please add tests for it.

michaeltout · 2024-10-03T20:34:59Z

src/pbaas/VdxfUniValue.ts

this comment I don't believe is addressed yet. I see that you've moved vectorEncodeVDXFUni (and the vice-versa functions) from an exported function, to a static function in the VdxfUniValue class. What i had in mind is that the vectorEncodeVDXFUni (and the related other functions) should be fully replaced by being integrated into the fromBuffer/toBuffer functions of VdxfUniValue. There should be no vectorEncodeVDXFUni, VDXFDataToUniValue, or VDXFDataToUniValueArray functions after this change, as their functionality should be covered in toBuffer/fromBuffer. I don't mind if you change the type of the "values" property to achieve this. Maybe we can call to discuss.

michaeltout · 2024-10-04T11:07:25Z

src/utils/types/SignData.ts

@@ -0,0 +1,8 @@
+export type SignData = {


Rename to SignDataParameters

michaeltout · 2024-10-04T11:08:05Z

src/utils/types/Signature.ts

@@ -0,0 +1,9 @@
+export type Signature = {


Rename to SignatureDataInfo

michaeltout · 2024-10-04T11:09:14Z

src/vdxf/classes/Attestation.ts

I'll revisit this when the changes we discussed are made regarding handling of attestations in login consent requests/responses.

michaeltout · 2024-10-04T11:13:13Z

src/vdxf/vdxfDataKeys.ts

Please rename this file to all lowercase to match its surrounding files

michaeltout · 2024-10-04T11:13:19Z

src/vdxf/identityDataKeys.ts

Please rename this file to all lowercase to match its surrounding files

monkins1010 added 30 commits April 6, 2023 11:07

Enable Attestations

cd9ea98

Correct init of Attestations

4d36210

Typo

1af9783

add more constructors

154341c

add decision

4f556a0

Add attesation reply

348be7a

updates for data

818d978

Updates for types of premissions

1c99825

Refactor Permission Class

5130a1f

Challenge updated

19d25e1

Fix for blank array

9f5627e

Allow empty permission()

eef8770

Refactor RequestedPermission

1fd85f0

vdxfkey update

ec0ea10

Merge remote-tracking branch 'upstream/master'

0fb819a

Merge remote-tracking branch 'verus/master'

c8039df

Merge remote-tracking branch 'verus/master'

4fc7b95

update

4f22a13

Add Principals and TxDestination

4b4c6af

Start adding in the Identity Serializer

09ecb41

Remove dupliacate and add to index

917c6d0

Autosave 1:44 21/06/2023

c7e00c7

Push to principal addresses array

3b8bb5c

Adding contentmultimap processing

5274539

Updates to contentmultimap

14f0505

update addresses

5fc9631

Updates to Identity SErializer

1aa4cad

From object to buffer test pass

e447c41

Identity Serializer passing

9994c93

Merge remote-tracking branch 'verus/master'

bc8cf4a

monkins1010 added 5 commits May 17, 2024 14:39

change Request to just data type

bf7cd12

Extra keys to catagorize attestations viewed

236b468

update

2018f3d

update test

194f1be

Merge remote-tracking branch 'upstream/master' into attest

dff3b51

michaeltout requested changes Jul 15, 2024

View reviewed changes

monkins1010 force-pushed the attest branch 2 times, most recently from 1bf27c8 to dff3b51 Compare August 20, 2024 16:09

monkins1010 added 6 commits August 20, 2024 19:49

Add SignData

a2432b3

update dist

35ceb68

Updates to code base from code reveiew comments.

d71f45b

Updates to comments for review

b6b37bb

Merge remote-tracking branch 'upstream/master' into attest

6731259

Build dist Update

d6dc753

update json key names and make consistent json functions

32464f4

michaeltout requested changes Oct 4, 2024

View reviewed changes

monkins1010 added 11 commits October 8, 2024 16:32

Updates to VdxfUniValue

4491a5a

More updates to VdxfUniValue

9818850

Update identity tests with new contentmap style

da760f4

Updates for tests VerusCoin#1

c1c3856

Tests updates

b6c596d

Remove Helper function and combine into fromBuffer

6e13097

Fix capitals commit 1

cfceb6c

Fix Capitals complete.

ec2919f

Fix serializers and add tests

032524e

update test

f2f1fbb

Update dist

979735d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Attestations V2 #23

Attestations V2 #23

monkins1010 commented Jan 31, 2024

michaeltout left a comment

michaeltout Jul 14, 2024

michaeltout Jul 14, 2024

michaeltout Jul 14, 2024

michaeltout Jul 14, 2024

michaeltout Jul 14, 2024

michaeltout Jul 15, 2024

michaeltout Jul 15, 2024

michaeltout Jul 15, 2024

monkins1010 Oct 2, 2024

michaeltout Jul 15, 2024

michaeltout Jul 15, 2024

monkins1010 commented Oct 2, 2024

monkins1010 commented Oct 2, 2024

monkins1010 commented Oct 3, 2024

michaeltout left a comment

michaeltout Oct 3, 2024

michaeltout Oct 3, 2024

michaeltout Oct 3, 2024

michaeltout Oct 3, 2024

michaeltout Oct 3, 2024

michaeltout Oct 4, 2024

michaeltout Oct 4, 2024

michaeltout Oct 4, 2024

michaeltout Oct 4, 2024

michaeltout Oct 4, 2024

Attestations V2 #23

Are you sure you want to change the base?

Attestations V2 #23

Conversation

monkins1010 commented Jan 31, 2024

michaeltout left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monkins1010 commented Oct 2, 2024

monkins1010 commented Oct 2, 2024

monkins1010 commented Oct 3, 2024

michaeltout left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment