Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payments): add 'tip' as supported line type #426

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

VictorAvelar
Copy link
Owner

@VictorAvelar VictorAvelar commented Dec 11, 2024

Description

This PR enables to add "tip" as a supported payment line type.

Motivation and context

Mollie has added this type of line item to better support their in person payment experience, this is useful for restaurants and other type of payment collectors that receive tips as an additional line item.

Closes #425

Checklist

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • If my change requires a change to the documentation, I have updated it accordingly.

@github-actions github-actions bot added the core label Dec 11, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation labels Dec 11, 2024
@VictorAvelar VictorAvelar merged commit dc4b2e4 into master Dec 11, 2024
10 checks passed
@VictorAvelar VictorAvelar deleted the add-tip-as-line-item-category-for-payments branch December 11, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tip as LineItem supported type.
1 participant