-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a minimum value to display tags in widget #242
base: master
Are you sure you want to change the base?
Conversation
The tag list in the Tag widget can be very long. With such feature, it is possible to limit to the most used tags.
When the widget list is truncated, it could be useful to have a direct link to the page listing all the available tags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't realize how this change could help us to fix the problem (very long tag list).
Example: you have tons of tags, you exclude (1)-tags from the widget. One year later: you have tons of (2)-tags, etc. Depending on the number of new entries per month and how you tag posts, the problem will come back again (and again). Most of those who have encountered a problem will set this parameter only once. The current proposal may be interesting for an individual site(s), but not for the theme itself.
WordPress shows 45 tags in the widget by default. Maybe we should provide some similar option (disabled by default) via config?
P.S. My apologies for the slow reply; long vacation without reliable internet and my dev machine.
Yes, you're right, this pull-request is not so focussed in containing the tag list under a given number. It is most oriented on filtering not so interesting tags as they are not so reused. Personally, I find it useful as I have plenty of tag used a single time. And I imagine that a tag used only once is not really interesting to discover content on my blog. |
As I said, I understand that this feature can be useful, but not for the theme itself. Why? Because it doesn't solve our problem. Our problem still here. So first of all we need a limiter, not a specific filter.
It's confusing. You have plenty of one-post tags, you don't want to show them in the widget, but you consider them as valuable nonetheless. How many one-post tags turned to two-post tags? I think there are only a few of them in the best-case scenario. Anyhow, if you need this kind of functionality, you should make a custom widget and place it inside I plan to close this PR if you don't mind. The problem is real, but the solution must be reconsidered and generalized. If we want to solve the problem, then I think we need a simple limiter. |
The tag list in the Tag widget can be very long.
With such feature, it is possible to limit to the most used tags.