Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Theme Toggle Button Enhancement #91

Closed
Vin-Jex opened this issue Oct 3, 2024 · 2 comments · Fixed by #95 · May be fixed by #93
Closed

[Bug]: Theme Toggle Button Enhancement #91

Vin-Jex opened this issue Oct 3, 2024 · 2 comments · Fixed by #95 · May be fixed by #93
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers Up for grab Available

Comments

@Vin-Jex
Copy link
Owner

Vin-Jex commented Oct 3, 2024

Describe the bug
I believe the ball inside of the container should not overflow or overlay the parent container.

To Reproduce
Steps to reproduce the behavior:

  1. Visit dent clack domain or url
  2. In the top navigation, you would find a theme toggle button.
  3. You will notice that the toggle UI is not good enough

Expected behavior

  • The toggle container should be bigger than the ball inside it
  • There should be a transitioning effect when toggling theme.

Screenshots
Screenshot 2024-10-03 at 7 37 19 AM

Desktop (please complete the following information):

  • On any OS
  • Browser: Any browser

Smartphone (please complete the following information):

  • Device: iPhone
  • On any browser.
@Vin-Jex Vin-Jex added bug Something isn't working enhancement New feature or request good first issue Good for newcomers Up for grab Available labels Oct 3, 2024
@gaurimadan
Copy link

@Vin-Jex i would like to take this issue

@Anthony-Chima
Copy link
Collaborator

Anthony-Chima commented Oct 4, 2024 •
edited
Loading

I believe I have fixed this issue when assigned to updating the top Nabar I just need to make a pull request for code review, so can I get assigned this issue.

@Vin-Jex Vin-Jex linked a pull request Oct 7, 2024 that will close this issue
Feat: Add Logo, Improve Toggle, Update The Current TopNav #77 #95
Merged
@Vin-Jex Vin-Jex linked a pull request Oct 27, 2024 that will close this issue
updated dark theme toggle animation #93
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers Up for grab Available
Projects
None yet
Milestone
No milestone
3 participants
@Vin-Jex @gaurimadan @Anthony-Chima