Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated dark theme toggle animation #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

updated dark theme toggle animation #93

wants to merge 1 commit into from

Conversation

gaurimadan
Copy link

added a spring animation in button switch
a fade in fade out transition in color transition

@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dentclack ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 6:54pm

@gaurimadan
Copy link
Author

@Vin-Jex please review this PR

Vin-Jex
Vin-Jex reviewed Oct 7, 2024
View reviewed changes
Copy link
Owner

@Vin-Jex Vin-Jex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch has a merge conflict, please update your branch and resolve merge conflict. Thank you!

@gaurimadan
Copy link
Author

sure

@Vin-Jex
Copy link
Owner

Vin-Jex commented Oct 27, 2024

@gaurimadan Please resolve the merge conflict and adjust the positioning of the ball so it fits perfectly within the rounded parent toggle container. Once this is fixed, I'll proceed with merging your PR.

@Vin-Jex Vin-Jex added enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktoberfest participate EddieHub:good-first-issue labels Oct 27, 2024
@Vin-Jex Vin-Jex linked an issue Oct 27, 2024 that may be closed by this pull request
[Bug]: Theme Toggle Button Enhancement #91
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vin-Jex Vin-Jex Vin-Jex left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@gaurimadan gaurimadan

Labels
EddieHub:good-first-issue enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktoberfest participate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Theme Toggle Button Enhancement
2 participants
@gaurimadan @Vin-Jex