Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Predicates #4

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Support Predicates #4

wants to merge 3 commits into from

Conversation

Vipul-Cariappa
Copy link
Owner

@Vipul-Cariappa Vipul-Cariappa commented Dec 4, 2023

Support to encode:

  • P (x) and Q (x, y, z)
  • ∀x.P (x)
  • ∃x.P (x)

Support to prove using:

  • Universal instantiation
  • Universal generalization
  • Existential instantiation
  • Existential generalization
  • Demorgans laws for "ForAll" and "ThereExists" i.e. ¬(∀x.P (x)) = ∃x.¬P (x)

Todos:

  • Add Tests
  • Update README.md with examples

Vipul-Cariappa added 2 commits December 3, 2023 11:02
(may be broken)

- should add test cases
- should add ability to prove using Universal/Existential Generalization
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 132 lines in your changes are missing coverage. Please review.

Comparison is base (60d8313) 76.93% compared to head (433f4fa) 70.46%.

Files Patch % Lines
logic/proposition.py 59.03% 102 Missing ⚠️
logic/proof.py 60.56% 28 Missing ⚠️
logic/utils.py 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   76.93%   70.46%   -6.48%     
==========================================
  Files           3        4       +1     
  Lines         477      816     +339     
==========================================
+ Hits          367      575     +208     
- Misses        110      241     +131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant