Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple separate build targets #3126

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Support multiple separate build targets #3126

wants to merge 8 commits into from

Commits on Aug 23, 2024

  1. Nit:Remove argument that is same as default 

    Nit:Remove maybeUpdateProjectTargetUri as ProjectName always has targetUriOpt set

Nit: Add named arguments to a buildOnce call
    @MaciejG604
    MaciejG604 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c8e168c View commit details
    Browse the repository at this point in the history

  2. NIT: Just to make reviewing easier: 

    - copy HasGeneratedSources.scala into ManagesBuildTargets.scala
- copy HasGeneratedSourcesImpl.scala into ManagesBuildTargetsImpl.scala.
    @MaciejG604
    MaciejG604 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    ef8ccb4 View commit details
    Browse the repository at this point in the history

  3. Change HasGeneratedSources to ManagesBuildTargets 

    Use ProjectName class instead of plain String
    @MaciejG604
    MaciejG604 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    56d19b1 View commit details
    Browse the repository at this point in the history

  4. Add BspClient to the BspServer constructor arguments

    @MaciejG604
    MaciejG604 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    efcfd58 View commit details
    Browse the repository at this point in the history

  5. Add InputsComposer for reading .toml file and creating a sequence of … 

    …inputs for further processing

Implement a new trait Inputs, that aggregates ModuleInputs

Use InputsComposer in Bsp and SetupIde

Add method for picking the highest version of JVM from BuildOptions
    @MaciejG604
    MaciejG604 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    d913c05 View commit details
    Browse the repository at this point in the history

  6. Move logging bsp messages to verbosity 2

    @MaciejG604
    MaciejG604 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c43cbb7 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Prevent exception with maxBy() on empty collection

    @MaciejG604
    MaciejG604 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    7c31518 View commit details
    Browse the repository at this point in the history

  2. Apply fmt

    @MaciejG604
    MaciejG604 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    1621853 View commit details
    Browse the repository at this point in the history