docs: 📝 Apple Vision Pro support in progress #108
clippy
7 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 7 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.75.0 (82e1608df 2023-12-21)
- cargo 1.75.0 (1d8b05cdd 2023-11-20)
- clippy 0.1.75 (82e1608d 2023-12-21)
Annotations
Check warning on line 763 in alvr/launcher/src/main.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr/launcher/src/main.rs:763:24
|
763 | fs::create_dir_all(&installation_dir)?;
| ^^^^^^^^^^^^^^^^^ help: change this to: `installation_dir`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
Check warning on line 761 in alvr/launcher/src/main.rs
github-actions / clippy
variable does not need to be mutable
warning: variable does not need to be mutable
--> alvr/launcher/src/main.rs:761:9
|
761 | let mut installation_dir = data_dir().extended(VERSIONS_SUBDIR).extended(&release.tag);
| ----^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
Check warning on line 759 in alvr/launcher/src/main.rs
github-actions / clippy
unused variable: `buffer`
warning: unused variable: `buffer`
--> alvr/launcher/src/main.rs:759:9
|
759 | let buffer = download(tx, "Downloading Streamer", &url, client).await?;
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_buffer`
|
= note: `#[warn(unused_variables)]` on by default
Check warning on line 782 in alvr/launcher/src/main.rs
github-actions / clippy
unreachable expression
warning: unreachable expression
--> alvr/launcher/src/main.rs:782:5
|
765 | / match installation_type {
766 | | #[cfg(target_os = "linux")]
767 | | InstallationType::AppImage => {
768 | | installation_dir.push("ALVR-x86_64.AppImage");
... |
780 | | }
781 | | }
| |_____- any code following this `match` expression is unreachable, as all arms diverge
782 | Ok(())
| ^^^^^^ unreachable expression
|
= note: `#[warn(unreachable_code)]` on by default
Check warning on line 6 in alvr/launcher/src/main.rs
github-actions / clippy
unused import: `Permissions`
warning: unused import: `Permissions`
--> alvr/launcher/src/main.rs:6:22
|
6 | fs::{self, File, Permissions},
| ^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
Check warning on line 128 in alvr/dashboard/src/dashboard/components/setup_wizard.rs
github-actions / clippy
unused variable: `ui`
warning: unused variable: `ui`
--> alvr/dashboard/src/dashboard/components/setup_wizard.rs:128:18
|
128 | |ui| {
| ^^ help: if this is intentional, prefix it with an underscore: `_ui`
|
= note: `#[warn(unused_variables)]` on by default
Check warning on line 74 in alvr/server_io/src/openvrpaths.rs
github-actions / clippy
accessing first element with `from_openvr_paths(paths_json).get(0)`
warning: accessing first element with `from_openvr_paths(paths_json).get(0)`
--> alvr/server_io/src/openvrpaths.rs:74:5
|
74 | from_openvr_paths(paths_json).get(0).cloned().to_any()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `from_openvr_paths(paths_json).first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default