Issue 1062 known offenders improvements #1160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added vhp.csv to double check it is being used. Edited tag trends htm to check if I was able to route changed routing in tag_trends.js
But still no output
Tried a different way to implement the code based off of online examples
opposed to just d3 Added a test.csv in order to edit the information and organize it in the proper format.
I used anychart as opposed to d3
see if I can get d3 working.
is to see how we get the data using ajax calls
the specifics of nodes and paths
Also added a setData function within tag_trends And cleaned up the code a tad bit since it was looking very full
Fixed some rails test errors Deleted redundant files Merged the newest master branch with this.
for the insights.controller file
controller -Added a new query to the tag model -Made sure that the controller validates the options
it was fully validating all of the options
-worked a bit on the openapi.yml file -commenting out endpoint stuff
endpoint, should work.
meeting with josh -finished the openapi.yml file in accordance with openapi notation.
json during failure. - Added as symbol to routes.rb for extra routing help - Added invalid/valid input test to tags_controller_test - Added test data to tags.yml, vulnerabilities.yml, and vulnerability_tags.yml - Created tag_test.rb file for the model to check the raw sql statement being run.
…ct/vulnerability-history into issue-1091-tagoverlaps
…lityHistoryProject/vulnerability-history into issue-1040-TagTrendsEndpoint
-Reverted changes to master -Separated entirely from issue-1040-TagTrendsEndpoint
tag.overlaps -added shortnames descriptor to openapi.yml -changed tag_test.rb to only have cve's as a test as opposed to giant string
-Changed insights_controller to interact with the insights model.
-This was done in order to fix certain tests
Also updated routing to match new format.
- Cleared any extra space or old debugging comments
-Additionally added some tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace this with the text of what you did/doing
Have you...
Gemfile.lockandyarn.lockare't getting modified unintentionally?The above things are not required, but appreciated.