Configuration Endpoint, PSR-2, Add tests (#1) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunaczech
commented
May 26, 2016
•
hunaczech
commented
- integrate tracy debug, endpoint for configuration profiles
- added circleci, standards psr2
* integrate tracy debug, endpoint for configuration profiles * added circleci with autodeploy, standards psr2 * remove autodeploy
| throw new ActionNotFoundException(sprintf('Controller "%s" not found', $controller_name)); | ||
| } | ||
| if (!method_exists($controller_class, $action)) { | ||
| throw new ActionNotFoundException(sprintf($action, ' for controller "%s" not found', $controller_name)); |
There was a problem hiding this comment.
@hunaczech
Jsou zde chybně zapsány argumenty. Správně by to mělo být:
sprintf('"%s" for controller "%s" not found', $action, $controller_name)V aktuálním formátu by to vypsalo pouze hodnotu $action
Prosím o opravu
There was a problem hiding this comment.
Fixnu, btw. podivej se pres annotate kdo to psal :)
There was a problem hiding this comment.
Respektive je to z tvého pull requestu 😄
* WIP - added md5 to image * Add possibilities to exclude images * Add more images to excluded
* Resize & Place command to make fixed rect * Set all profiles as square
* Command for render new profile images * Loading file doesn't create new MD5 file hash * Saving file doesn't create new MD5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.