Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per-repo user-specific diff statistics to graph output #28

Closed
wants to merge 4 commits into from
Closed

Add per-repo user-specific diff statistics to graph output #28

wants to merge 4 commits into from

Conversation

alecello
Copy link
Member

@alecello alecello commented Nov 8, 2020

A new graph is generated in each one of the per-repo figure with a bar graph containing the all-time and yearly diff statistics for each contributor for that specific repo.

The new graph is a stacked bar graph with two colors, the familiar green and red for added and removed lines.

@alecello
Copy link
Member Author

alecello commented Nov 8, 2020

Should close #7

@e-caste e-caste self-assigned this Nov 8, 2020
@e-caste
Copy link
Member

e-caste commented Nov 8, 2020

I see 3 issues in an example diff histogram here:

  • one name does not display correctly
  • many numbers are written on top of each other when the bars are short
  • of the 3 numbers (deleted, added, total) I can only see the number of deleted lines and the total

Screenshot 2020-11-08 at 18 29 28

Could you address these issues?

@e-caste e-caste linked an issue Nov 8, 2020 that may be closed by this pull request
@alecello
Copy link
Member Author

alecello commented Nov 8, 2020

Regarding point 3: There is no total, just deleted and created lines

@e-caste
Copy link
Member

e-caste commented Nov 8, 2020

@alecello I believe it is not clear then. Best way is to change how the data is displayed, a number in the middle of the bar is not very readable

@alecello
Copy link
Member Author

alecello commented Nov 8, 2020

Ok, it's going to take a lot more time than anticipated. Since I can't complete this right now (needs to rewrite a bunch of code), I'm marking this as draft until ready

@alecello alecello marked this pull request as draft November 8, 2020 19:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add stats about lines by developer
2 participants