Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forces encoding of XML to UTF-8 prior to converting to JSON #2895

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −0
Open

Forces encoding of XML to UTF-8 prior to converting to JSON #2895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/controllers/api_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,15 @@ def show
# escape double quotes (because they may appear in node values)
xml = xml.gsub(%(\"), %(\\\"))

# Non-ASCII characters that are valid UTF-8 will throw an error during
# the translation process. Since we want UTF-8 in and out, forcing
# encoding to UTF-8 here should alleviate issues of where a multibyte
# char is not recognized. However, if non UTF-U encodings are being
# used, then this still may error, and we need to re-open the discussion
# about how/wehther to support other encodings, which would have to be
# stored/read within the PBCore documents themselves, i would think.
xml.force_encoding('UTF-8')

json = pbcore_xml_to_json_xsl_doc.transform(Nokogiri::XML(xml))
render json: JSON.pretty_generate(
JSON.parse(json)
Expand Down
Loading