Skip to content

Commit

Permalink
try to fix isoline rendering in makie 2d
Browse files Browse the repository at this point in the history
  • Loading branch information
j-fu committed Jun 2, 2023
1 parent ba8f6d1 commit 85bf8cf
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions src/makie.jl
Original file line number Diff line number Diff line change
Expand Up @@ -635,14 +635,16 @@ function makescene2d(ctx, key)
ctx[key];
width = 10,
ticks = unique(ctx[:cbarticks]),
tickformat = "{:.2e}",
)
elseif ctx[:colorbar] == :horizontal
GL[2, 1] = XMakie.Colorbar(
ctx[:figure],
ctx[key];
height = 10,
ticks = ctx[:cbarticks],
ticks = unique(ctx[:cbarticks]),
vertical = false,
tickformat = "{:.2e}",
)
end
GL
Expand All @@ -666,11 +668,11 @@ function scalarplot!(ctx, TP::Type{MakieType}, ::Type{Val{2}}, grids, parentgrid
end

if elevation 0.0
points = Vector{Point2f}(undef, sum(npoints))
points = Vector{Point3f}(undef, sum(npoints))
k = 1
for j = 1:ngrids
for i = 1:npoints[j]
points[k] = Point2f(coords[j][1, i], coords[j][2, i])
points[k] = Point3f(coords[j][1, i], coords[j][2, i], -0.1)
k = k + 1
end
end
Expand Down

2 comments on commit 85bf8cf

@j-fu
Copy link
Member Author

@j-fu j-fu commented on 85bf8cf Jun 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/84784

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.1.0 -m "<description of version>" 85bf8cf3f1de54649bd43951d90f4ddb8db79aa0
git push origin v1.1.0

Please sign in to comment.